lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Jun 2014 08:57:58 -0700 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Yijing Wang <wangyijing@...wei.com> Cc: Marc Dionne <marc.c.dionne@...il.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, stable@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>, Ben Hutchings <ben@...adent.org.uk> Subject: Re: [PATCH 3.4 214/214] HID: logitech: dont use stack based dj_report structures On Thu, Jun 05, 2014 at 08:12:08PM +0800, Yijing Wang wrote: > >> - dj_report.report_type = REPORT_TYPE_CMD_GET_PAIRED_DEVICES; > >> - return logi_dj_recv_send_report(djrcv_dev, &dj_report); > >> + dj_report = kzalloc(sizeof(dj_report), GFP_KERNEL); > > > > This patch was unfortunately incorrect as is - it needs to allocate > > sizeof(struct dj_report) here and a little further down. This was > > later fixed in mainline by 8a55ade7655, which should also be included > > if you take this - I don't see it in the current set. > > Good catch, I'm so sorry, I missed this fix patch. Marc, thanks for your review. > > Hi Greg, Can you cherry pick this fix patch? upstream commit id: 8a55ade7655(dj: memory scribble in logi_dj). Now applied, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists