linux-kernel - Re: [PATCH] Documentation, intel_pstate: Add a description of the intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5390A1B7.3050008@infradead.org>
Date:	Thu, 05 Jun 2014 09:58:31 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Prarit Bhargava <prarit@...hat.com>, linux-kernel@...r.kernel.org
CC:	Viresh Kumar <viresh.kumar@...aro.org>,
	Dirk Brandewie <dirk.brandewie@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	"David S. Miller" <davem@...emloft.net>,
	Ramkumar Ramachandra <artagnon@...il.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH] Documentation, intel_pstate: Add a description of the
 intel_pstate internal governors [v2]

On 06/05/2014 08:07 AM, Prarit Bhargava wrote:
> The current documentation is incomplete wrt the intel_pstate internal
> governors.  The confusion comes from the general use internal governors
> which also use the names performance and powersave.  This patch
> differentiates between the two sets of governors.
> 
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Dirk Brandewie <dirk.brandewie@...il.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Jesper Nilsson <jesper.nilsson@...s.com>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Ramkumar Ramachandra <artagnon@...il.com>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: linux-doc@...r.kernel.org
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>
> 
> [v2]: text update
> ---
>  Documentation/cpu-freq/governors.txt    |    2 +-
>  Documentation/cpu-freq/intel-pstate.txt |    8 ++++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/cpu-freq/governors.txt b/Documentation/cpu-freq/governors.txt
> index 77ec215..c15aa75 100644
> --- a/Documentation/cpu-freq/governors.txt
> +++ b/Documentation/cpu-freq/governors.txt
> @@ -36,7 +36,7 @@ Contents:
>  1. What Is A CPUFreq Governor?
>  ==============================
>  
> -Most cpufreq drivers (in fact, all except one, longrun) or even most
> +Most cpufreq drivers (except the intel_pstate and longrun) or even most
>  cpu frequency scaling algorithms only offer the CPU to be set to one
>  frequency. In order to offer dynamic frequency scaling, the cpufreq
>  core must be able to tell these drivers of a "target frequency". So
> diff --git a/Documentation/cpu-freq/intel-pstate.txt b/Documentation/cpu-freq/intel-pstate.txt
> index e742d21..2edd8d9 100644
> --- a/Documentation/cpu-freq/intel-pstate.txt
> +++ b/Documentation/cpu-freq/intel-pstate.txt
> @@ -9,6 +9,14 @@ assumed to implement internal governors by the cpufreq core. All the
>  logic for selecting the current P state is contained within the
>  driver; no external governor is used by the cpufreq core.
>  
> +The Intel P-state driver has two internal governors, performance and
> +powersave.  These governors differ from the generally used governors of the
> +same name in the kernel.  The internal performance governor sets the
> +max_perf_pct and min_perf_pct to 100; that is, the governor selects the
> +highest available P state to maximize the performance of the core.  The
> +internal powersave governor, selects the appropriate P state based on the

no comma here  ---------------^

> +current load on the CPU.
> +
>  Intel SandyBridge+ processors are supported.
>  
>  New sysfs files for controlling P state selection have been added to
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/