linux-kernel - Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for am43x-epos-evm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 15:26:11 +0530
From:	George Cherian <george.cherian@...com>
To:	Nishanth Menon <nm@...com>, <tony@...mide.com>,
	<bcousson@...libre.com>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: am43x-epos-evm: Add Missing cpsw-phy-sel for
 am43x-epos-evm

On 6/6/2014 12:25 PM, Nishanth Menon wrote:
> On 06/06/2014 01:53 AM, Nishanth Menon wrote:
>> On 06/06/2014 01:17 AM, George Cherian wrote:
>>> AM437x EPOS evm use external clock for RMII interface.
>>> Enable the same in DT.
>>>
>>> Signed-off-by: George Cherian <george.cherian@...com>
>>> Reported-by: Nishanth Menon <nm@...com>
>>> ---
>>>   arch/arm/boot/dts/am43x-epos-evm.dts | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
>>> index 19f1f7e..90098f9 100644
>>> --- a/arch/arm/boot/dts/am43x-epos-evm.dts
>>> +++ b/arch/arm/boot/dts/am43x-epos-evm.dts
>>> @@ -319,6 +319,10 @@
>>>   	phy-mode = "rmii";
>>>   };
>>>   
>>> +&phy_sel {
>>> +	rmii-clock-ext;
>>> +};
>>> +
>>>   &i2c0 {
>>>   	status = "okay";
>>>   	pinctrl-names = "default";
>>>
>> Where does this apply on?
>> With linux-next next-20140506 tag, and this patch applied, I get the
>> following error.
>>
>>    LD      kernel/trace/built-in.o
>>    LD      kernel/built-in.o
>> build fail, Error:
>> Error: arch/arm/boot/dts/am43x-epos-evm.dts:219.2-3 label or path,
>> 'phy_sel', not found
>> FATAL ERROR: Syntax error parsing input tree
>> make[1]: *** [arch/arm/boot/dts/am43x-epos-evm.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [dtbs] Error 2
>> make: *** Waiting for unfinished jobs....
>>
>> in the future, it is helpful if you can point out that this is a
>> regression seen on next-20140603 and the patch needs to be applied on
>> some specific branch.
>>
>> for the record:
>> last working next tag:
>> https://github.com/nmenon/kernel-test-logs/blob/next-20140602/omap2plus_defconfig/am43xx-epos.txt
>>
>> first broken next tag:
>> https://github.com/nmenon/kernel-test-logs/blob/next-20140603/omap2plus_defconfig/am43xx-epos.txt
>>
>>
> interestingly, i just re-tested today's tag without the patch
> (omap2plus_defconfig):
> http://slexy.org/raw/s205sRdFvy
Lil old kernel
from the above link.

Linux version 3.15.0-rc4-next-20140506 (nmenon@...una) (gcc version 
4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5) ) #2 SMP Fri Jun 6 01:47:42 CDT 2014
> I wonder why the behavior change and what was being fixed here?
This kernel should not have the dt entries for phy sel driver.
Thats why it is working.


-- 
-George

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/