linux-kernel - Re: [PATCH 2/2] perf tests: Show the inner make output when an error happens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 16:50:23 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>,
	Don Zickus <dzickus@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 2/2] perf tests: Show the inner make output when an error
 happens

On Fri, Jun 06, 2014 at 11:11:49AM -0300, Arnaldo Carvalho de Melo wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
> 
> Before:
> 
>   [acme@zoo linux]$ make -C tools/perf -f tests/make make_static
>   make: Entering directory `/home/git/linux/tools/perf'
>   - make_static: cd . && make -f Makefile DESTDIR=/tmp/tmp.JcWuM4Zu9f LDFLAGS=-static
>   make: *** [make_static] Error 1
>   make: Leaving directory `/home/git/linux/tools/perf'
>   [acme@zoo linux]$
> 
> After:
> 
>   [acme@zoo linux]$ make -C tools/perf -f tests/make make_static
>   make: Entering directory `/home/git/linux/tools/perf'
>   - make_static: cd . && make -f Makefile DESTDIR=/tmp/tmp.X3su83i14u LDFLAGS=-static
>   cd . && make -f Makefile DESTDIR=/tmp/tmp.X3su83i14u LDFLAGS=-static
>     BUILD:   Doing 'make -j4' parallel build
>   config/Makefile:303: *** No static glibc found, please install glibc-static.  Stop.
>   make[1]: *** [all] Error 2
>     test: test -x ./perf
>   make: Leaving directory `/home/git/linux/tools/perf'
>   [acme@zoo linux]$
> 
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: David Ahern <dsahern@...il.com>
> Cc: Don Zickus <dzickus@...hat.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Mike Galbraith <efault@....de>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Stephane Eranian <eranian@...gle.com>
> Link: http://lkml.kernel.org/n/tip-s3ycajsl9n249n9e8gomfex5@git.kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/tests/make | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/tests/make b/tools/perf/tests/make
> index 2f92d6e7ee00..c21db653b1f2 100644
> --- a/tools/perf/tests/make
> +++ b/tools/perf/tests/make
> @@ -205,8 +205,7 @@ $(run):
>  	( eval $$cmd ) >> $@ 2>&1; \
>  	echo "  test: $(call test,$@)" >> $@ 2>&1; \
>  	$(call test,$@) && \
> -	rm -f $@ \
> -	rm -rf $$TMP_DEST
> +	rm -rf $@ $$TMP_DEST || cat $@

I like that we show the log, but we need to fail the target
so the processing is stopped and the rest is not executed,
like adding this:

    .... cat $@ && false
>  
>  $(run_O):
>  	$(call clean)

also you need to put same change to $(run_O) target

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/