linux-kernel - Re: [PATCH v2] ARM: fix debug prints relevant to PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Jun 2014 21:23:12 -0700
From:	Joe Perches <joe@...ches.com>
To:	Vidya Sagar <vidyas@...dia.com>
Cc:	linux@....linux.org.uk, bhelgaas@...gle.com, wangyijing@...wei.com,
	thierry.reding@...il.com, jason@...edaemon.net,
	will.deacon@....com, swarren@...dia.com, kthota@...dia.com,
	sagar.tv@...il.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ARM: fix debug prints relevant to PCI devices

On Fri, 2014-06-06 at 00:17 +0530, Vidya Sagar wrote:
> * replaced printk with pr_info
[]
> diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
[]
> @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
>  
>  	/*
>  	 * Report what we did for this bus
> +	 * (only if the bus doesn't have even one PCIe device)
>  	 */
> -	printk(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
> -		bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");
> +	if (!has_pcie_dev)
> +		pr_info(KERN_INFO "PCI: bus%d: Fast back to back transfers %sabled\n",
> +			bus->number, (features & PCI_COMMAND_FAST_BACK) ? "en" : "dis");

when you convert to pr_<level> you need to remove the
KERN_<LEVEL> from the format string too.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/