| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Jun 2014 19:34:30 +0200 From: Ken Helias <kenhelias@....de> To: Andrew Morton <akpm@...ux-foundation.org> Cc: linux-kernel@...r.kernel.org, Ken Helias <kenhelias@...email.de>, linux-scsi@...r.kernel.org, target-devel@...r.kernel.org Subject: [PATCH 11/13] iscsi-target: Use list_add_(before|after) macros From: Ken Helias <kenhelias@...email.de> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias <kenhelias@...email.de> Cc: linux-scsi@...r.kernel.org Cc: target-devel@...r.kernel.org --- drivers/target/iscsi/iscsi_target_erl1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index cda4d80..1926d0b 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c @@ -835,8 +835,8 @@ static int iscsit_attach_ooo_cmdsn( continue; /* Insert before this entry */ - list_add(&ooo_cmdsn->ooo_list, - ooo_tmp->ooo_list.prev); + list_add_before(&ooo_cmdsn->ooo_list, + &ooo_tmp->ooo_list); break; } } -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists