[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 6 Jun 2014 19:34:27 +0200
From: Ken Helias <kenhelias@....de>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, Ken Helias <kenhelias@...email.de>,
linux-wireless@...r.kernel.org
Subject: [PATCH 08/13] mac80211: Use list_add_(before|after) macros
From: Ken Helias <kenhelias@...email.de>
Many places in the code uses list_add_tail/list_add to insert an entry
before/after another entry. This confuses the reader because these are usually
used to add an item to a list_head and not an entry. Better use the self
explaining function name.
Signed-off-by: Ken Helias <kenhelias@...email.de>
Cc: linux-wireless@...r.kernel.org
---
net/mac80211/cfg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index d7513a5..110c42b 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -2822,7 +2822,7 @@ static int ieee80211_start_roc_work(struct ieee80211_local *local,
if (new_dur > 0) {
/* add right after tmp */
- list_add(&roc->list, &tmp->list);
+ list_add_after(&roc->list, &tmp->list);
} else {
list_add_tail(&roc->list,
&tmp->dependents);
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists