linux-kernel - Re: new driver: w1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 17:46:50 -0000
From:	Scott Alfter <scott@...ter.us>
To:	linux-kernel@...r.kernel.org
Cc:	zbr@...emap.net, greg@...ah.com
Subject: Re: new driver: w1_ds2406

On Thu, June 5, 2014 10:44, Evgeniy Polyakov wrote:
> 04.06.2014, 08:25, "Scott Alfter" <scott@...ter.us>:
>> I have a project for which I needed support for the DS2406 addressable
>> switch, so I started with an existing driver and modified it as needed.
>> It allows the switch outputs to be controlled over the bus, which is
>> what I needed from it.
>
> Driver seems good, although debug prints like 'mutex is locked' are better
> to be dropped.

Those were in the DS2413 driver, which I used as a base for my changes. 
I've taken them out.  Also, I fixed a typo I made in the description in a
Kconfig file.

> Please send this patch to linux-kernel@ and add me and greg@...ah.com to
> copy, and patch will be pulled upstream.
> Feel free to add my acked/reviewed-by tags.

Signed-off-by: Scott Alfter <scott@...ter.us>
Acked-by: Evgeniy Polyakov <zbr@...emap.net>
Reviewed-by: Evgeniy Polyakov <zbr@...emap.net>

View attachment "w1_ds2406.patch.txt" of type "text/plain" (6439 bytes)