linux-kernel - Re: [PATCH] mtip32xx: minor performance enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 06 Jun 2014 12:55:57 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Sam Bradshaw <sbradshaw@...ron.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtip32xx: minor performance enhancements

On 06/06/2014 01:01 PM, Sam Bradshaw wrote:
> This patch adds the following:
> 
> 1) Compiler hinting in the fast path.
> 2) A prefetch of port->flags to eliminate moderate cpu stalling later 
> in mtip_hw_submit_io().
> 3) Eliminate a redundant rq_data_dir().
> 4) Reorder members of driver_data to eliminate false cacheline sharing 
> between irq_workers_active and unal_qdepth.
> 
> With some workload and topology configurations, I'm seeing ~1.5% 
> throughput improvement in small block random read benchmarks as well
> as improved latency std. dev.

Seems I got a small bump in peak perf as well. In any case, it's
innocuous, so should do no harm to apply.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/