linux-kernel - Re: [GIT PULL] x86/vdso changes for v3.16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Jun 2014 14:09:54 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Peter Anvin <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Sasha Levin <sasha.levin@...cle.com>,
	Stefani Seibold <stefani@...bold.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: Re: [GIT PULL] x86/vdso changes for v3.16

On Fri, Jun 6, 2014 at 2:07 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Fri, Jun 6, 2014 at 2:00 PM, Andrew Morton <akpm@...ux-foundation.org> wrote:
>>
>> arch/x86/vdso/vdso2c.h: In function 'go64':
>> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le64toh'
>> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le32toh'
>> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le16toh'
>> arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16'
>>
>> My Fedora Core 6 (lol gotcha) test box doesn't have these.
>
> Suggested fix: only use the helper functions on non-x86 (or
> non-little-endian) platforms.
>
> Peter, Andy?

The only real downside to that would be the chance of bitrot if that
code isn't getting used on native builds.

Blech.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/