linux-kernel - Re: [GIT PULL] x86/vdso changes for v3.16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Jun 2014 14:37:20 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andy Lutomirski <luto@...capital.net>
CC:	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Sasha Levin <sasha.levin@...cle.com>,
	Stefani Seibold <stefani@...bold.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pavel Emelyanov <xemul@...allels.com>
Subject: Re: [GIT PULL] x86/vdso changes for v3.16

On 06/06/2014 02:33 PM, Andy Lutomirski wrote:
> On Fri, Jun 6, 2014 at 2:25 PM, H. Peter Anvin <hpa@...or.com> wrote:
>> On 06/06/2014 02:22 PM, Andy Lutomirski wrote:
>>>
>>> Sounds good.
>>>
>>> In the mean time, a trivial fix is here:
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=vdso/cleanup_fixes&id=cf780a0dc71f7cbd9a417e6ce2d5ddf56abccb74
>>>
>>> (or it will be once the mirrors sync)
>>>
>>
>> Unfortunately gcc didn't introduce __BYTE_ORDER__ at the compiler level
>> until 2010.  This makes it harder to do this in a portable manner.
> 
> Is there anything wrong with using __get_unaligned_leNN directly?
> 

Minus the double underscore (these files need to be cleaned up), not
really, and that is what my patch does.

For accessing memory members doing it via a pointer is pretty much TRT,
but for things that might be in register it is undesirable to force it
out to memory.

	-hpa



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/