lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 7 Jun 2014 00:03:52 +0200 From: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> To: Bart Van Assche <bvanassche@....org> Cc: Anil Gurumurthy <anil.gurumurthy@...gic.com>, Sudarsana Kalluru <sudarsana.kalluru@...gic.com>, "James E.J. Bottomley" <JBottomley@...allels.com>, linux-scsi@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] scsi: bfa: bfad_attr.c: Optimization of the Code Hi Several have remarked in the other patch for strncpy I posted. That there is a strlcpy that works exactly as one would like to strncpy was done :) And the return value is like for snprintf, but quite a lot faster! So I submit patches based with it instead, and did a couple more exchanges of snprintf to strlcpy. Best regards Rickard Strandqvist 2014-06-05 9:10 GMT+02:00 Bart Van Assche <bvanassche@....org>: > On 06/05/14 08:55, Bart Van Assche wrote: >> On 06/04/14 20:08, Rickard Strandqvist wrote: >> This is ugly. Please use sprintf(buf, "%.*s\n", PAGE_SIZE - 1, str) >> instead of strncpy() + strlen(). > > (replying to my own e-mail) > > The above should of course have read "sprintf(buf, "%.*s\n", PAGE_SIZE - > 2, str)" to avoid that the terminating '\0' triggers a buffer overflow. > > Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists