linux-kernel - Re: [PATCH] net: wimax: i2400m: control.c: Cleaning up conjunction always evaluates to false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402141375.28369.2.camel@joe-AO725>
Date:	Sat, 07 Jun 2014 04:42:55 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Inaky Perez-Gonzalez <inaky.perez-gonzalez@...el.com>,
	linux-wimax@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: wimax: i2400m: control.c:  Cleaning up conjunction
 always evaluates to false

On Sat, 2014-06-07 at 13:26 +0200, Rickard Strandqvist wrote:
> Logical conjunction always evaluates to false:  minor < 2 && minor > 1
> I guess what you wanted is rather: minor > 2 || minor < 1
[]
> diff --git a/drivers/net/wimax/i2400m/control.c b/drivers/net/wimax/i2400m/control.c
[]
> @@ -1061,7 +1061,7 @@ int i2400m_firmware_check(struct i2400m *i2400m)
>  		goto error_bad_major;
>  	}
>  	result = 0;
> -	if (minor < I2400M_HDIv_MINOR_2 && minor > I2400M_HDIv_MINOR)
> +	if (minor > I2400M_HDIv_MINOR_2 || minor < I2400M_HDIv_MINOR)

perhaps clearer as:

	if (!(minor == I2400M_HDIv_MINOR || minor == I2400M_HDIv_MINOR_2))

>  		dev_warn(dev, "untested minor fw version %u.%u.%u\n",
>  			 major, minor, branch);
>  	/* Yes, we ignore the branch -- we don't have to track it */



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/