linux-kernel - Re: [PATCH 03/13] list: Add list_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140607133400.GA13329@infradead.org>
Date:	Sat, 7 Jun 2014 06:34:00 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	Ken Helias <kenhelias@....de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Ken Helias <kenhelias@...email.de>,
	Dipankar Sarma <dipankar@...ibm.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Oleg Nesterov <oleg@...hat.com>, Dave Jones <davej@...hat.com>
Subject: Re: [PATCH 03/13] list: Add list_add_(before|after) macros

On Fri, Jun 06, 2014 at 12:51:35PM -0700, Hugh Dickins wrote:
> I'll express my opinion: perhaps it's widely shared, perhaps it is not.
> 
> I think a patch like this (and the subsequent conversions) is unhelpful
> churn.
> 
> The Linux struct list_head is designed and intended to be used for both
> head and entry, and introducing aliases to make unnecessary distinctions
> just hinders development instead of helping it.
> 
> If the reader is confused at first, I hope the reader will soon learn,
> without needing to rely on aliases such as these.

I fully concur with Hugh - the list_head is symmetric for heads vs
entires, and lots of code depends on that.

In addition to that multiple functions that do exactly the same thing
generall are a bad idea.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/