linux-kernel - Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 07 Jun 2014 08:56:08 -0500
From:	Seth Jennings <sjennings@...iantweb.net>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Linux-MM <linux-mm@...ck.org>
Subject: Re: [PATCH 1/1] mm/zswap.c: add __init to zswap_entry_cache_destroy


On Jun 7, 2014 6:08 AM, Fabian Frederick <fabf@...net.be> wrote:
>
> zswap_entry_cache_destroy is only called by __init init_zswap 
>
> This patch also fixes function name 
> zswap_entry_cache_ s/destory/destroy

Thanks for the  improvement ☺

Acked-by <sjennings@...iantweb.net>

>
> Cc: Seth Jennings <sjennings@...iantweb.net> 
> Cc: linux-mm@...ck.org 
> Cc: Andrew Morton <akpm@...ux-foundation.org> 
> Signed-off-by: Fabian Frederick <fabf@...net.be> 
> --- 
> mm/zswap.c | 4 ++-- 
> 1 file changed, 2 insertions(+), 2 deletions(-) 
>
> diff --git a/mm/zswap.c b/mm/zswap.c 
> index aeaef0f..ab7fa0f 100644 
> --- a/mm/zswap.c 
> +++ b/mm/zswap.c 
> @@ -207,7 +207,7 @@ static int zswap_entry_cache_create(void) 
> return zswap_entry_cache == NULL; 
> } 
>
> -static void zswap_entry_cache_destory(void) 
> +static void __init zswap_entry_cache_destroy(void) 
> { 
> kmem_cache_destroy(zswap_entry_cache); 
> } 
> @@ -926,7 +926,7 @@ static int __init init_zswap(void) 
> pcpufail: 
> zswap_comp_exit(); 
> compfail: 
> - zswap_entry_cache_destory(); 
> + zswap_entry_cache_destroy(); 
> cachefail: 
> zbud_destroy_pool(zswap_pool); 
> error: 
> -- 
> 1.9.1 
>