linux-kernel - Re: [PATCH] dts: Add UARTs to am335x-bone-common.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Jun 2014 10:06:13 -0500
From:	Robert Nelson <robertcnelson@...il.com>
To:	"Matwey V. Kornilov" <matwey@....msu.ru>
Cc:	Benoit Cousson <bcousson@...libre.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	devicetree <devicetree@...r.kernel.org>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dts: Add UARTs to am335x-bone-common.dtsi

On Sat, Jun 7, 2014 at 9:48 AM, Matwey V. Kornilov <matwey@....msu.ru> wrote:
> From 739cee0aded1aac80764b3fca4e801464f199f93 Mon Sep 17 00:00:00 2001
> From: "Matwey V. Kornilov" <matwey.kornilov@...il.com>
> Date: Sat, 7 Jun 2014 17:23:57 +0400
> Subject: [PATCH] Add UARTs to am335x-bone-common.dtsi
>
> Add four UARTs pinouts and ports to beagle bone common dtsi.
>
> Signed-off-by: Matwey V. Kornilov <matwey@....msu.ru>
> ---
>  arch/arm/boot/dts/am335x-bone-common.dtsi | 48
> +++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi
> b/arch/arm/boot/dts/am335x-bone-common.dtsi
> index 2e7d932..da3db9f 100644
> --- a/arch/arm/boot/dts/am335x-bone-common.dtsi
> +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi
> @@ -90,6 +90,30 @@
>                         0x174 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /*
> uart0_txd.uart0_txd */
>                 >;
>         };
> +       uart1_pins: pinmux_uart1_pins {
> +               pinctrl-single,pins = <
> +                       0x180 (PIN_INPUT_PULLUP | MUX_MODE0)    /*
> uart1_rxd.uart1_rxd */
> +                       0x184 (PIN_OUTPUT_PULLDOWN | MUX_MODE0) /*
> uart1_txd.uart1_txd */
> +               >;
> +       };
> +       uart2_pins: pinmux_uart2_pins {
> +               pinctrl-single,pins = <
> +                       0x150 (PIN_INPUT_PULLUP | MUX_MODE1)    /*
> spi0_sclk.uart2_rxd */
> +                       0x154 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /*
> spi0_d0.uart2_txd */
> +               >;
> +       };
> +       uart3_pins: pinmux_uart3_pins {
> +               pinctrl-single,pins = <
> +       /* Pin 0x160 spi0_cs1.uart3_rxd is not exported to the expansion
> header. The port is half-duplex */
> +                       0x164 (PIN_OUTPUT_PULLDOWN | MUX_MODE1) /*
> ecap0_in_pwm0_out.uart3_txd */
> +               >;
> +       };
> +       uart4_pins: pinmux_uart4_pins {
> +               pinctrl-single,pins = <
> +                       0x070 (PIN_INPUT_PULLUP | MUX_MODE6)    /*
> gpmc_wait0.uart4_rxd */
> +                       0x074 (PIN_OUTPUT_PULLDOWN | MUX_MODE6) /*
> gpmc_wpn.uart4_txd */
> +               >;
> +       };
>
>         clkout2_pin: pinmux_clkout2_pin {
>                 pinctrl-single,pins = <
> @@ -179,6 +203,30 @@
>
>         status = "okay";
>  };
> +&uart1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart1_pins>;
> +
> +       status = "okay";
> +};
> +&uart2 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart2_pins>;
> +
> +       status = "okay";
> +};
> +&uart3 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart3_pins>;
> +
> +       status = "okay";
> +};
> +&uart4 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&uart4_pins>;
> +
> +       status = "okay";
> +};

These need to stay disabled in mainline, so drop the status = "okay";
, (till we get a working capemgr/overlay). Otherwise the pinmuxing
looks good.

Regards,

-- 
Robert Nelson
http://www.rcn-ee.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/