linux-kernel - [PATCH] staging: bcm: nvm.c: Cleaning up a array that is filled incompletely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1402263928-1961-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Date:	Sun,  8 Jun 2014 23:45:27 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lisa Nguyen <lisa@...apiadmin.com>
Cc:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Tugce Sirin <ztugcesirin@...il.com>,
	Masanari Iida <standby24x7@...il.com>,
	Wenliang Fan <fanwlexca@...il.com>,
	Rashika Kheria <rashika.kheria@...il.com>,
	Aldo Iljazi <neonsync1@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] staging: bcm: nvm.c:  Cleaning up a array that is filled incompletely  

Hi

I think someone missed the count sizeof type in memcpy.

I'm no expert on this code.
But I wonder if also the the next for loop wrong?
It will fill with 0XFF00000000000000 but it is
not a complete 0XFFFFFFFFFFFFFFFF you're looking for?

So something like:
memset(&Buff[sigOffset], 0xFF, MAX_RW_SIZE * sizeof(PCHAR));

Rickard Strandqvist (1):
  MY_FIL_NAMN Cleaning up a array that is filled incompletely

 drivers/staging/bcm/nvm.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/