linux-kernel - Re: [linux-nics] [PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1402217625.3039.1.camel@jtkirshe-mobl>
Date:	Sun, 08 Jun 2014 01:53:45 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ken Helias <kenhelias@....de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	devel@...verdev.osuosl.org, bridge@...ts.linux-foundation.org,
	b.a.t.m.a.n@...ts.open-mesh.org, NICS <linux.nics@...el.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	Ken Helias <kenhelias@...email.de>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Linux@...tope.jf.intel.com, linux-fsdevel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: Re: [linux-nics] [PATCHv3 2/3] list: Fix order of arguments for
 hlist_add_after(_rcu)

On Sat, 2014-06-07 at 18:40 +0200, Ken Helias wrote:
> From: Ken Helias <kenhelias@...email.de>
> 
> All other add functions for lists have the new item as first argument
> and the
> position where it is added as second argument. This was changed for no
> good
> reason in this function and makes using it unnecessary confusing.
> 
> The name was changed to let old code generate a compile errors instead
> of
> using the wrong parameter order.
> 
> Signed-off-by: Ken Helias <kenhelias@...email.de>
> Cc: Linux NICS <linux.nics@...el.com>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: e1000-devel@...ts.sourceforge.net
> Cc: netdev@...r.kernel.org
> Cc: devel@...verdev.osuosl.org
> Cc: linux-fsdevel@...r.kernel.org
> Cc: b.a.t.m.a.n@...ts.open-mesh.org
> Cc: bridge@...ts.linux-foundation.org

For the Intel driver changes...
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

> ---
> Patch based on "Add linux-next specific files for 20140606"
> 
> v3:
> renamed from hlist_add_after* to hlist_add_behind
> 
> v2:
> Splitted into two patches
> reduced number of Cc
> 
>  Documentation/RCU/whatisRCU.txt                  | 2 +-
>  drivers/gpu/drm/drm_hashtab.c                    | 2 +-
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c   | 2 +-
>  drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +-
>  drivers/staging/lustre/lustre/libcfs/hash.c      | 4 ++--
>  fs/namespace.c                                   | 2 +-
>  fs/notify/inode_mark.c                           | 2 +-
>  fs/notify/vfsmount_mark.c                        | 2 +-
>  include/linux/list.h                             | 4 ++--
>  include/linux/rculist.h                          | 8 ++++----
>  net/batman-adv/fragmentation.c                   | 2 +-
>  net/bridge/br_multicast.c                        | 2 +-
>  net/ipv4/fib_trie.c                              | 2 +-
>  net/ipv6/addrlabel.c                             | 2 +-
>  net/xfrm/xfrm_policy.c                           | 4 ++--
>  15 files changed, 21 insertions(+), 21 deletions(-)



Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)