linux-kernel - Re: [PATCH 2/7] lib/random32.c: Remove excess calls to prandom_u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140608121909.899.qmail@ns.horizon.com>
Date:	8 Jun 2014 08:19:09 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	dborkman@...hat.com, linux@...izon.com
Cc:	davem@...emloft.net, hannes@...essinduktion.org,
	linux-kernel@...r.kernel.org, shemminger@...l.org, tytso@....edu
Subject: Re: [PATCH 2/7] lib/random32.c: Remove excess calls to prandom_u32_state in initialization

Thank you for your time and attention on all these comments.

> Fine by me although we simply resembled initialization code from
> GSL here. I think that your subject line is a bit misleading though.

Yes, I had a hard time coming up with a good summary.  I'm removing
*static* calls but not dynamic ones.

How about "don't unroll one-time initialization code"?
Would that be a better way to put it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/