linux-kernel - Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d2eid5e7.fsf@sejong.aot.lge.com>
Date:	Mon, 09 Jun 2014 14:21:52 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Andi Kleen <ak@...ux.intel.com>
Cc:	Andi Kleen <andi@...stfloor.org>, jolsa@...hat.com,
	linux-kernel@...r.kernel.org, acme@...radead.org,
	fweisbec@...il.com
Subject: Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

On Wed, 4 Jun 2014 09:59:30 -0700, Andi Kleen wrote:
> I saw samples.
>
> Oh well we can just drop it. The only difference is that the 
> event list cannot set a period then.

I tested with a downloaded event, and it does have samples.  But the
frequency could not be changed even with your patch.

  $ perf record -a -e uops_retired.all -F 4000 sleep 1
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.327 MB perf.data (~14281 samples) ]

  $ perf evlist -F
  cpu/uops_retired.all/: sample_freq=2000003

>
> It's as broken as before.

At least, it worked well for events don't have a default sample
freq/period which means all but tracepoint events.  For tracepoint
events, it makes little sense to change the default so I decided not to
touch it.  

But with your change, the downloaded events might have a default
freq/period setting now.  So I'd like to make it right.  I'll send a fix
for this right soon.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/