linux-kernel - Re: [PATCH 1/1] platform/chrome: Probe multiple i2c adapters of the same name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140609124700.GJ1657@lahna.fi.intel.com>
Date:	Mon, 9 Jun 2014 15:47:00 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Scot Doyle <lkml14@...tdoyle.com>
Cc:	Benson Leung <bleung@...omium.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Olof Johansson <olof@...om.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] platform/chrome: Probe multiple i2c adapters of the
 same name

On Fri, Jun 06, 2014 at 11:25:14PM +0100, Scot Doyle wrote:
> The chromeos_laptop module probes the first i2c adapter with a specific name
> for expected hardware. However, the Acer C720 Chromebook has two i2c
> adapters with the same name. This patch probes each i2c adapter with a
> specific name in turn, until locating the expected hardware.
> 
> Signed-off-by: Scot Doyle <lkml14@...tdoyle.com>
> CC: Benson Leung <bleung@...omium.org>
> CC: Mika Westerberg <mika.westerberg@...ux.intel.com>

I don't have anything against this approach.

One comment though, if you happen to have two devices with the same
address but in different buses this can go wrong. Not sure how likely
that will happen.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/