linux-kernel - Re: [PATCH 1/1] include/linux/memblock.h: add __init to memblock_set_bottom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53950B92.6040504@cn.fujitsu.com>
Date:	Mon, 9 Jun 2014 09:19:14 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	Fabian Frederick <fabf@...net.be>
CC:	<linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] include/linux/memblock.h: add __init to memblock_set_bottom_up

Seeing from the code, it is OK.

Reviewed-by: Tang Chen<tangchen@...fujitsu.com>

Thanks.

On 06/07/2014 02:21 PM, Fabian Frederick wrote:
> memblock_set_bottom_up is only called by
> __init cmdline_parse_movable_node and __init numa_init.
>
> Cc: Andrew Morton<akpm@...ux-foundation.org>
> Cc: Tang Chen<tangchen@...fujitsu.com>
> Signed-off-by: Fabian Frederick<fabf@...net.be>
> ---
> This is untested.
>
>   include/linux/memblock.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index 8a20a51..4d6dfcf 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -198,7 +198,7 @@ phys_addr_t memblock_alloc(phys_addr_t size, phys_addr_t align);
>   /*
>    * Set the allocation direction to bottom-up or top-down.
>    */
> -static inline void memblock_set_bottom_up(bool enable)
> +static inline void __init memblock_set_bottom_up(bool enable)
>   {
>   	memblock.bottom_up = enable;
>   }
> @@ -213,7 +213,7 @@ static inline bool memblock_bottom_up(void)
>   	return memblock.bottom_up;
>   }
>   #else
> -static inline void memblock_set_bottom_up(bool enable) {}
> +static inline void __init memblock_set_bottom_up(bool enable) {}
>   static inline bool memblock_bottom_up(void) { return false; }
>   #endif
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/