linux-kernel - Re: [PATCH v2] hwmon: (ina2xx) Cast to s16 on shunt and current regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5395C88C.5070408@roeck-us.net>
Date:	Mon, 09 Jun 2014 07:45:32 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Fabio Baltieri <fabio.baltieri@...il.com>,
	Jean Delvare <jdelvare@...e.de>
CC:	lm-sensors@...sensors.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] hwmon: (ina2xx) Cast to s16 on shunt and current regs

On 06/08/2014 02:06 PM, Fabio Baltieri wrote:
> All devices supported by ina2xx are bidirectional and reports the
> measured shunt voltage and power values as a signed 16 bit, but the
> current driver implementation caches all registers as u16, leading to an
> incorrect sign extension when reporting to the userspace in
> ina2xx_get_value().
>
> This patch fixes the problem by casting the signed registers to s16.
> Tested on an INA219.
>
> Signed-off-by: Fabio Baltieri <fabio.baltieri@...il.com>

Applied.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/