linux-kernel - Re: [PATCH v6] NVMe: conversion to blk-mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5395D24D.9000306@fb.com>
Date:	Mon, 9 Jun 2014 09:27:09 -0600
From:	Jens Axboe <axboe@...com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Ming Lei <tom.leiming@...il.com>, Matias Bj??rling <m@...rling.me>,
	<willy@...ux.intel.com>, <keith.busch@...el.com>,
	<sbradshaw@...ron.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH v6] NVMe: conversion to blk-mq

On 2014-06-09 08:59, Christoph Hellwig wrote:
> On Mon, Jun 09, 2014 at 08:08:50AM -0600, Jens Axboe wrote:
>>> [  487.704074] nvme 0000:00:07.0: Cancelling I/O 202 QID 1
>>> [  487.717881] nvme 0000:00:07.0: Aborting I/O 202 QID 1
>>> [  487.736093] end_request: I/O error, dev nvme0n1, sector 91532352
>>> [  487.747378] nvme 0000:00:07.0: completed id 0 twice on queue 0
>>>
>>>
>>> when running fio randread(libaio, iodepth:64) with more than 3 jobs.
>>>
>>> And looks no such failure when jobs is 1 or 2.
>>
>> It's a known issue, make sure you have this patch:
>>
>> https://urldefense.proofpoint.com/v1/url?u=http://git.kernel.dk/?p%3Dlinux-block.git%3Ba%3Dcommit%3Bh%3Df6be4fb4bcb396fc3b1c134b7863351972de081f&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=3JMVyziIyZtZ5cv9eWNLwQ%3D%3D%0A&m=MKK7A%2B9AnXXwtMV9YPSFEprXId0z0WLtd2JQPxnaNVc%3D%0A&s=45425e5d17390ae912457035ff081b95a7084725706ffe91166a1bdb25d8bf3d
>
> So without this patch we can get duplicate completions?  That could
> explain the issues that Robert sees with scsi-mq and hpsa..

I don't see how that would happen in general, except if the timeout
part was buggy.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/