linux-kernel - Re: [PATCH] blk-mq: add timer in blk_mq_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5395DEA4.90000@kernel.dk>
Date:	Mon, 09 Jun 2014 10:19:48 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <tom.leiming@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-mq: add timer in blk_mq_start_request

On 06/09/2014 10:16 AM, Ming Lei wrote:
> This way will become consistent with non-mq case, also
> avoid to update rq->deadline twice for mq.
> 
> The comment said: "We do this early, to ensure we are on
> the right CPU.", but no percpu stuff is used in blk_add_timer(),
> so it isn't necessary. Even when inserting from plug list, there
> is no such guarantee at all.

Thanks, this is a good cleanup. That particular comment predates the
strict mappings of the queues, so it doesn't apply anymore anyway.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/