linux-kernel - Re: [PATCHv2 2/3] IIO: Add iio_chan modifier for True/Magnetic North HID usages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5395F44F.8010005@kernel.org>
Date:	Mon, 09 Jun 2014 18:52:15 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Reyad Attiyat <reyad.attiyat@...il.com>,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	srinivas.pandruvada@...ux.intel.com, linux-input@...r.kernel.org,
	jkosina@...e.cz
Subject: Re: [PATCHv2 2/3] IIO: Add iio_chan modifier for True/Magnetic North
 HID usages

On 09/06/14 18:51, Jonathan Cameron wrote:
> On 03/06/14 00:14, Reyad Attiyat wrote:
>> Updated iio modifier enum for compass north usages,
>> including magnetic/true north with tilt compensation.
>>
>> Signed-off-by: Reyad Attiyat <reyad.attiyat@...il.com>
> This looks fine.
gah. With the from_ prefix you suggested of course!
>> ---
>>   drivers/iio/industrialio-core.c | 4 ++++
>>   include/linux/iio/types.h       | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
>> index ede16aec..2f523b5 100644
>> --- a/drivers/iio/industrialio-core.c
>> +++ b/drivers/iio/industrialio-core.c
>> @@ -84,6 +84,10 @@ static const char * const iio_modifier_names[] = {
>>       [IIO_MOD_LIGHT_RED] = "red",
>>       [IIO_MOD_LIGHT_GREEN] = "green",
>>       [IIO_MOD_LIGHT_BLUE] = "blue",
>> +    [IIO_MOD_NORTH_MAGN] = "north_magnetic",
>> +    [IIO_MOD_NORTH_TRUE] = "north_true",
>> +    [IIO_MOD_NORTH_MAGN_TILT_COMP] = "north_magnetic_tilt_comp",
>> +    [IIO_MOD_NORTH_TRUE_TILT_COMP] = "north_true_tilt_comp",
>>   };
>>
>>   /* relies on pairs of these shared then separate */
>> diff --git a/include/linux/iio/types.h b/include/linux/iio/types.h
>> index 084d882..5bf8847 100644
>> --- a/include/linux/iio/types.h
>> +++ b/include/linux/iio/types.h
>> @@ -53,6 +53,10 @@ enum iio_modifier {
>>       IIO_MOD_LIGHT_RED,
>>       IIO_MOD_LIGHT_GREEN,
>>       IIO_MOD_LIGHT_BLUE,
>> +    IIO_MOD_NORTH_MAGN,
>> +    IIO_MOD_NORTH_TRUE,
>> +    IIO_MOD_NORTH_MAGN_TILT_COMP,
>> +    IIO_MOD_NORTH_TRUE_TILT_COMP
>>   };
>>
>>   enum iio_event_type {
>>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/