linux-kernel - Re: [PATCHv3 2/3] regulator: s2mps11: Add support S2MPU02 regulator device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140609195543.GK5099@sirena.org.uk>
Date:	Mon, 9 Jun 2014 20:55:43 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	lee.jones@...aro.org, sbkim73@...sung.com, sameo@...ux.intel.com,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org,
	myungjoo.ham@...sung.com, kyungmin.park@...sung.com,
	jonghwa3.lee@...sung.com, k.kozlowski@...sung.com
Subject: Re: [PATCHv3 2/3] regulator: s2mps11: Add support S2MPU02 regulator
 device

On Mon, Jun 09, 2014 at 03:15:47PM +0900, Chanwoo Choi wrote:
> This patch add S2MPU02 regulator device to existing S2MPS11 device driver
> because of little difference between S2MPS1x and S2MPU02. The S2MPU02
> regulator device includes LDO[1-28] and BUCK[1-7].

Acked-by: Mark Brown <broonie@...aro.org>

but a few nits:

> +	case S2MPS14X:
> +		switch (rdev_id) {
> +		case S2MPS14_LDO3:
> +			return 0;
> +		};

Extra ; here, and a missing default case here and in the rest of the
switches.  The default cases have no effect but are better style.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)