linux-kernel - Re: [PATCH v2] coccinelle: Check for missing NULL terminators in of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 09 Jun 2014 14:50:42 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Michal Marek <mmarek@...e.cz>
CC:	Julia Lawall <julia.lawall@...6.fr>, linux-kernel@...r.kernel.org,
	Mitchel Humpherys <mitchelh@...eaurora.org>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <nicolas.palix@...g.fr>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH v2] coccinelle: Check for missing NULL terminators in
 of_device_id tables

On 06/09/14 14:47, Michal Marek wrote:
> Dne 3.6.2014 20:25, Julia Lawall napsal(a):
>> From: Stephen Boyd <sboyd@...eaurora.org>
>>
>> Failure to terminate an of_device_id table can lead to confusing
>> failures depending on where the compiler places the array. Add a
>> check to make sure these tables are terminated. Thanks to Mitchel
>> Humpherys for coming up with the pattern initially.
>>
>> Cc: Mitchel Humpherys <mitchelh@...eaurora.org>
>> Cc: Julia Lawall <Julia.Lawall@...6.fr>
>> Cc: Gilles Muller <Gilles.Muller@...6.fr>
>> Cc: Nicolas Palix <nicolas.palix@...g.fr>
>> Cc: Grant Likely <grant.likely@...aro.org>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: devicetree@...r.kernel.org
>> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
>> Acked-by: Grant Likely <grant.likely@...aro.org>
>> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
>>
>> ---
>>
>> v3: Removed unneeded rule bad_of_table.  Placed * in context rule on the 
>> closing brace; putting it on the field caused all fields to be marked.
>>
>> v4: corrected authorship
>>
>>  scripts/coccinelle/misc/of_table.cocci |   62 +++++++++++++++++++++++++++++++++
>>  1 file changed, 62 insertions(+)
> Applied to kbuild.git#misc, thanks. BTW, what is so special about of
> device drivers? Shouldn't we check for missing sentinels in all kinds of
> device tables?
>

Yes the rule should probably be expanded to cover more tables. I guess
this is just more noticeable because a driver may match some device that
it isn't supposed to match and start writing random bits to registers it
shouldn't be, causing the system to hang.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/