linux-kernel - Re: HID: hid-sensor-hub: fix sleeping function called from invalid context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5396409D.5000501@linux.intel.com>
Date:	Mon, 09 Jun 2014 16:17:49 -0700
From:	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Alexander Holler <holler@...oftware.de>,
	linux-kernel@...r.kernel.org,
	Reyad Attiyat <reyad.attiyat@...il.com>
Subject: Re: HID: hid-sensor-hub: fix sleeping function called from invalid
 context

On 06/09/2014 03:40 PM, Jiri Kosina wrote:
> On Tue, 10 Jun 2014, Alexander Holler wrote:
>
>> Hello,
>>
>> while rebasing the dozens (currently around 60) of refused, ignored or
>> similiar bugfixes and patches I need to use a Linux kernel, I've noticed that
>> Jiri Kosinas patch here
>>
>> https://lkml.org/lkml/2013/8/9/214
>>
>> doesn't apply anymore.
>>
>> Looking why, I've seen that a similiar patch from Srinivas Pandruvada named
>> like the topic ended up in the kernel.
>
> Hi Alexander,
>
> thanks for drawing this one from the boulevard of forgotten patches.
>
> I am actually not aware of any patch by Srinivas that would conflict with
> the one I've written -- could you please elaborate where you believe the
> conflict is?
>
>> Looking at the differences, I wonder if not all spin_lock() calls in
>> hid-sensor-hub.c should be changed into spin_lock_irqsave() like the
>> patch from Jiri Kosina did.
>

There is a patch submitted by "reyad.attiyat@...il.com"
[PATCH] HID: hid-sensor-hub: Fix lockdep warning for dynamic callback locks.

Already doing this, what you suggested?

+Reyad


Thanks,
Srinivas


> Could you please give me your Tested-by:? I'll then be happily queuing the
> fix. Thanks.
>
>> (sorry for the duplicate message, I've forgotten to add the
>> wanna-be-reviewer-school named lkml to the recipients)
>
> You want to make it to LWN quotes of the week, don't you? :)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/