linux-kernel - Re: [patch V3 1/7] rtmutex: Deobfuscate chain walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539680E4.1090303@cn.fujitsu.com>
Date:	Tue, 10 Jun 2014 11:52:04 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, Jason Low <jason.low2@...com>,
	Brad Mouring <bmouring@...com>
Subject: Re: [patch V3 1/7] rtmutex: Deobfuscate chain walk

On 06/10/2014 04:59 AM, Steven Rostedt wrote:
> On Mon, 09 Jun 2014 20:28:06 -0000
> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
>> There is no point to keep the task ref across the check for lock
>> owner. Drop the ref before that, so the protection context is clear.
>>
>> Found while documenting the chain walk.
> 
> This looks fine, I just hate the subject. I don't see how it is
> 'deobfuscating" the chain walk. How about:
> 
> rtmutex: No need to keep task ref when checking lock ownership
> 
> Reviewed-by: Steven Rostedt <rostedt@...dmis.org>

Reviewed-by: Lai Jiangshan <laijs@...fujitsu.com>

Thanks,
Lai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/