linux-kernel - Re: [PATCH v3 1/3] crypto: qce: Qualcomm crypto engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Jun 2014 11:34:22 +0300
From:	Stanimir Varbanov <svarbanov@...sol.com>
To:	Joe Perches <joe@...ches.com>
CC:	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	"David S. Miller" <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Grant Likely <grant.likely@...aro.org>,
	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 1/3] crypto: qce: Qualcomm crypto engine driver

Hi Joe,

On 06/09/2014 07:46 PM, Joe Perches wrote:
> On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote:
>> The driver is separated by functional parts. The core part
>> implements a platform driver probe and remove callbaks.
>> The probe enables clocks, checks crypto version, initialize
>> and request dma channels, create done tasklet and init
>> crypto queue and finally register the algorithms into crypto
>> core subsystem.
> 
> trivia:
> 
>> diff --git a/drivers/crypto/qce/dma.h b/drivers/crypto/qce/dma.h
> []
>> +#define AUTH_NONCE_NUM_WORDS_SHIFT	20
>> +#define AUTH_NONCE_NUM_WORDS_MASK	GENMASK(22, 20);
> 
> Unnecessary semicolon and appears to be unused.

Will correct, thanks.

It is unused because I dropped out AEAD support from this set. I plan to
add AEAD incrementally later on.

-- 
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/