linux-kernel - Re: ipc/sem.c: change perform_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jun 2014 10:19:33 -0400
From:	Dave Jones <davej@...hat.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Manfred Spraul <manfred@...orfullife.com>, davidlohr.bueso@...com
Subject: Re: ipc/sem.c: change perform_atomic_semop parameters

On Fri, Jun 06, 2014 at 11:50:06PM +0000, Linux Kernel wrote:
 > Gitweb:     http://git.kernel.org/linus/;a=commit;h=d198cd6d6d02d0a335af2deacb60816ebb4719d1
 > Commit:     d198cd6d6d02d0a335af2deacb60816ebb4719d1
 > Parent:     2f2ed41dcaec34f2d6f224aa84efcc5a9dd8d5c3
 > Refname:    refs/heads/next
 > Author:     Manfred Spraul <manfred@...orfullife.com>
 > AuthorDate: Fri Jun 6 14:37:49 2014 -0700
 > Committer:  Linus Torvalds <torvalds@...ux-foundation.org>
 > CommitDate: Fri Jun 6 16:08:15 2014 -0700
 > 
 >     ipc/sem.c: change perform_atomic_semop parameters
 >     
 >     Right now, perform_atomic_semop gets the content of sem_queue as
 >     individual fields.  Changes that, instead pass a pointer to sem_queue.
 >     
 >     This is a preparation for the next patch: it uses sem_queue to store the
 >     reason why a task must sleep.
 >     
 >     Signed-off-by: Manfred Spraul <manfred@...orfullife.com>
 >     Cc: Davidlohr Bueso <davidlohr.bueso@...com>
 >     Cc: Michael Kerrisk <mtk.manpages@...il.com>
 >     Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
 >     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>

After this patch, coverity started complaining about a potential deref
after null check. (It may have been a problem before, but the code motion
causes a new 'event')

    	33. var_compare_op: Comparing un to null implies that un might be null.
1878        if (un && un->semid == -1)
1879                goto out_unlock_free;
1880
1881        queue.sops = sops;
1882        queue.nsops = nsops;
    	34. alias_transfer: Assigning: queue.undo = un.
1883        queue.undo = un;
1884        queue.pid = task_tgid_vnr(current);
1885        queue.alter = alter;
1886
    	
CID 1222114 (#1 of 1): Dereference after null check (FORWARD_NULL)
35. var_deref_model: Passing &queue to perform_atomic_semop, which dereferences null queue.undo. [show details]
1887        error = perform_atomic_semop(sma, &queue);


	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/