lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140610152255.GA20737@redhat.com>
Date:	Tue, 10 Jun 2014 11:22:55 -0400
From:	Dave Jones <davej@...hat.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	mporter@...aro.org, lee.jones@...aro.org
Subject: Re: regulator: bcm590xx: Add support for regulators on secondary I2C
 slave

On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote:
 > Gitweb:     http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f
 > Commit:     c6466950e917890be3050171f6745ccb9d91d35f
 > Parent:     9e1e726311830bc5b8b568d5178f6a52c357fb6e
 > Refname:    refs/heads/next
 > Author:     Matt Porter <mporter@...aro.org>
 > AuthorDate: Wed Apr 23 19:21:32 2014 -0400
 > Committer:  Lee Jones <lee.jones@...aro.org>
 > CommitDate: Wed May 21 10:40:16 2014 +0100
 > 
 >     regulator: bcm590xx: Add support for regulators on secondary I2C slave
 >     
 >     The bcm590xx MFD driver now exposes a secondary regmap descriptor
 >     making the registers for regulators on the secondary I2C slave address
 >     available.  Add support for GPLDO1-6 and VBUS regulators found within
 >     this register range.
 
 > -#define BCM590XX_NUM_REGS	20
 > +#define BCM590XX_NUM_REGS	27

Coverity picked up that this change has introduced a out of bounds read.
The loop in bcm590xx_probe iterates from 0 to NUM_REGS,
but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26
elements.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ