linux-kernel - perf tools: MULTILIB install issues. was Re: [PATCH 1/2] perf tools: Emit more precise message for missing glibc static library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140610181636.GA2794@kernel.org>
Date:	Tue, 10 Jun 2014 15:16:36 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Don Zickus <dzickus@...hat.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>,
	Kyle McMartin <kyle@...artin.ca>
Subject: perf tools: MULTILIB install issues. was Re: [PATCH 1/2] perf tools:
 Emit more precise message for missing glibc static library

Em Tue, Jun 10, 2014 at 11:50:31AM -0400, Don Zickus escreveu:
> I am hijacking your thread for another Makefile problem.  It seems like
> you were doing some cleanups here, so I wanted to throw another problem at
> you. :-)

Yeah, I skimmed that discussion about our home grown autoconf
replacement 8-)
 
> It seems the fedora-kernel guys found a multilib packaging problem and
> posted a patch to clean it up.  It is from Kyle McMartin
> (copy-n-pasted).
 
> +++ b/tools/perf/config/Makefile
> @@ -621,8 +621,12 @@ endif
>  ifeq ($(IS_X86_64),1)
>  lib = lib64
>  else
> +ifdef MULTILIBDIR
> +lib = $(MULTILIBDIR)
> +else
>  lib = lib
>  endif
> +endif
>  libdir = $(prefix)/$(lib)
 
>  # Shell quote (do not use $(call) to accommodate ancient setups);

> Not sure if this is the right way to do this or if you had a better
> solution.

I'm unsure as well, but it looks like something that suits the needs of
distros, right? Anyone?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/