linux-kernel - Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFo99gY9ROmVS56PeeAPxw6GgBnjLai3az0ABnE=1xcryDCRuA@mail.gmail.com>
Date:	Tue, 10 Jun 2014 22:48:35 +0200
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Valentina Manea <valentina.manea.m@...il.com>,
	devel@...verdev.osuosl.org, linux-usb@...r.kernel.org,
	navin patidar <navinp@...c.in>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: usbip: stub_main.c: Cleaning up missing
 null-terminate after strncpy call

Hi

True!
Sorry  :-(

But then one would either operate strcpy outright.

Or use strlcpy then the code would be:

    /* strlcpy() handles not include \0 */
    len = strlcpy(busid, buf + 4, BUSID_SIZE);

    /* busid needs to include \0 termination */
    if (!(len < BUSID_SIZE))
        return -EINVAL;


Or should we just let it be, perhaps?


Kind regards
Rickard Strandqvist


2014-06-10 8:57 GMT+02:00 Dan Carpenter <dan.carpenter@...cle.com>:
> On Wed, Jun 04, 2014 at 11:39:49PM +0200, Rickard Strandqvist wrote:
>> Added a guaranteed null-terminate after call to strncpy.
>>
>> This was partly found using a static code analysis program called cppcheck.
>>
>
> We already knew that the string was NUL terminated because we checked
> strnlen() on the lines before.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/