linux-kernel - Re: [PATCH Resend] cpufreq: tegra: update comment for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2122590.Au0hJVo2lP@vostro.rjw.lan>
Date:	Tue, 10 Jun 2014 23:15:20 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, arvind.chauhan@....com,
	swarren@...dia.com, dianders@...omium.org
Subject: Re: [PATCH Resend] cpufreq: tegra: update comment for clarity

On Tuesday, June 10, 2014 10:27:12 AM Viresh Kumar wrote:
> Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate
> frequency callbacks) and implements new 'intermediate freq' infrastructure of
> core. Above commit updated comments about when to call
> clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and
> said this:
> 
> > The "Though when target-freq is intermediate freq, we don't need to
> > take this reference." makes me think that this function is actually
> > called when target-freq is intermediate freq.  I don't think it is,
> > right?
> 
> For better clarity just make that comment more explicit about when we call
> tegra_target_intermediate().
> 
> Reviewed-by: Stephen Warren <swarren@...dia.com>
> Reported-and-reviewed-by: Doug Anderson <dianders@...omium.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
> Resend: Improved comment as suggested by Stephen.

Applied to bleeding-edge, thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/