linux-kernel - Re: [PATCH] of/platform: Fix microblaze build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5397AFCA.8030906@monstr.eu>
Date:	Wed, 11 Jun 2014 03:24:26 +0200
From:	Michal Simek <monstr@...str.eu>
To:	Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org
CC:	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	Michal Simek <monstr@...str.eu>, linux-kernel@...r.kernel.org,
	Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] of/platform: Fix microblaze build failure

On 06/10/2014 08:59 PM, Guenter Roeck wrote:
> Commit bf5db2f (microblaze: Use generic device.h) removes the
> microblaze specific pdev_archdata and dma_mask.
> 
> At the same time, commit 591c1ee (of: configure the platform
> device dma parameters) initializes the just removed field.
> This causes all microblaze builds to fail.
> 
> Drop the unnecessary initialization.
> 
> Cc: Michal Simek <michal.simek@...inx.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/of/platform.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 6c48d73..500436f 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -166,10 +166,6 @@ static void of_dma_configure(struct platform_device *pdev)
>  	int ret;
>  	struct device *dev = &pdev->dev;
>  
> -#if defined(CONFIG_MICROBLAZE)
> -	pdev->archdata.dma_mask = 0xffffffffUL;
> -#endif
> -
>  	/*
>  	 * Set default dma-mask to 32 bit. Drivers are expected to setup
>  	 * the correct supported dma_mask.
> 

Acked-by: Michal Simek <monstr@...str.eu>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)