linux-kernel - Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140611140648.GH10256@localhost>
Date:	Wed, 11 Jun 2014 16:06:48 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Janne Kanniainen <janne.kanniainen@...il.com>, cooloney@...il.com,
	linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-input@...r.kernel.org,
	johan@...nel.org
Subject: Re: [PATCH v3] leds: USB: HID: Add support for MSI GT683R led panels

On Wed, Jun 11, 2014 at 01:25:49PM +0200, Jiri Kosina wrote:
> On Wed, 11 Jun 2014, Janne Kanniainen wrote:
> 
> > This driver adds support for USB controlled led panels that exists in MSI GT683R laptop
> > 
> > Changes in v2:
> > 	- sorted headers to alphabetic order
> > 	- using devm_kzalloc
> > 	- using BIT(n)
> > 	- using usb_control_msg instead of usb_submit_urb
> > 	- removing unneeded code
> > 
> > Changes in v3:
> > 	- implemented as HID device
> > 	- some cleanups and bug fixes
> > 
> > Signed-off-by: Janne Kanniainen <janne.kanniainen@...il.com>
> 
> Thanks for the driver. Johan, as you did a very good job reviewing this 
> before I managed to get to it, I'd be glad to put your Reviewed-by: to the 
> commit before commiting it, if you are going to provide it.

I had a few more comments to v3, but I'll make sure to reply with a
Reviewed-by-tag before you apply.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/