linux-kernel - Re: vdso_install target broken post-3.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2014 11:20:30 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andy Lutomirski <luto@...capital.net>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: vdso_install target broken post-3.15

On Wed, Jun 11, 2014 at 11:18 AM, H. Peter Anvin <hpa@...or.com> wrote:
> On 06/11/2014 08:16 AM, Josh Boyer wrote:
>> On Wed, Jun 11, 2014 at 10:14 AM, Josh Boyer <jwboyer@...oraproject.org> wrote:
>>> Hi,
>>>
>>> I'm guessing commit 6f121e548f83674ab4920a4e60afb58d4f61b829 is what
>>> broke the vdso_install target:
>>>
>>> + make -s ARCH=x86_64
>>> INSTALL_MOD_PATH=/home/jwboyer/rpmbuild/BUILDROOT/kernel-3.16.0-0.rc0.git1.1.fc21.x86_64
>>> vdso_install KERNELRELEASE=3.16.0-0.rc0.git1.1.fc21.x86_64
>>> make[1]: *** No rule to make target `arch/x86/vdso/vdso.so.dbg',
>>> needed by `vdso.so'.  Stop.
>>> make: *** [vdso_install] Error 2
>>>
>>> The crazy Fedora versioning there corresponds to
>>> 3f17ea6dea8ba5668873afa54628a91aaa3fb1c0 in Linus' tree.  I'll poke at
>>> this some, but if you have some quick ideas I'd be happy to try them.
>>
>> OK, I'm stumped.  Looking at that commit, it removes all target
>> invocations for vdso.so.  Which means even a simple 'make' in the vdso
>> directory fails with:
>>
>> [jwboyer@...er vdso]$ make
>> make: *** No rule to make target `/vdso.so', needed by `/vdso.o'.  Stop.
>> [jwboyer@...er vdso]$
>>
>> So how was this commit build tested?
>>
>
> Since when do we support "make" in a subdirectory?

Dunno.  Since when do we break existing make targets that worked fine?

Seriously, I'm just asking how this was build tested so I can try and
duplicate that and then figure out how to fix the actual bug.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/