linux-kernel - Re: [PATCH v2] usb: host: uhci-grlib.c : use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1406111123071.890-100000@iolanthe.rowland.org>
Date:	Wed, 11 Jun 2014 11:24:10 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Himangi Saraogi <himangi774@...il.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Jan Andersson <jan@...sler.com>, <julia.lawall@...6.fr>
Subject: Re: [PATCH v2] usb: host: uhci-grlib.c : use devm_ functions

On Tue, 10 Jun 2014, Himangi Saraogi wrote:

> The various devm_ functions allocate memory that is released when a
> driver detaches. This patch uses devm_ioremap_resource for data
> that is allocated in the probe function of a platform device and
> is only freed in the remove function. The corresponding free functions
> are removed and two labels are done away with. Also, linux/device.h
> is added to make sure the devm_*() routine declarations are
> unambiguously available.
> 
> Signed-off-by: Himangi Saraogi <himangi774@...il.com>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
> ---
> v2: fix error of devm_ioremap_resource and change label names.


> +	hcd->regs = devm_ioremap_resource(&op->dev, hcd);

Obviously you haven't tried to compile this.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/