linux-kernel - Re: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of memory' messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1402502500.6169.5.camel@joe-AO725>
Date:	Wed, 11 Jun 2014 09:01:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andy Whitcroft <apw@...dowen.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [RFC PATCH] checkpatch: Attempt to find unnecessary 'out of
 memory' messages

On Wed, 2014-06-11 at 10:47 +0300, Dan Carpenter wrote:
> Acked-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> This check introduces 1849 new checkpatch.pl warnings.  I looked through
> the first 70 warnings and there were no false positives.

Thanks for checking Dan.

As your systems are much faster than mine, perhaps you could publish
the output of some script like:

$ git ls-files -- "*.[ch]" | while read file ; do \
	./scripts/checkpatch.pl -f --emacs --terse --no-summary --types=OOM_MESSAGE $file; \
  done

to someplace like kernel janitors.

That might prompt someone to submit patch series for them.

> Besides the bloat issue, I don't like these warnings because they make
> the error handling harder to read.  They are sort of a mindless thing
> that people feel they have to do for no particular reason.  Since
> people aren't thinking when they write the error message then you get
> NULL dereferences and so on.

Yeah, that too.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/