linux-kernel - Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3882689.ERRzduavD8@vostro.rjw.lan>
Date:	Wed, 11 Jun 2014 02:32:41 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Stratos Karafotis <stratosk@...aphore.gr>
Cc:	Dirk Brandewie <dirk.brandewie@...il.com>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	dirk.j.brandewie@...el.com,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] cpufreq: intel_pstate: Remove duplicate CPU ID check

On Tuesday, June 10, 2014 10:14:29 AM Dirk Brandewie wrote:
> On 06/09/2014 10:21 PM, Viresh Kumar wrote:
> > On 10 June 2014 02:30, Stratos Karafotis <stratosk@...aphore.gr> wrote:
> >> We check the CPU ID during driver init. There is no need
> >> to do it again per logical CPU initialization.
> >>
> >> So, remove the duplicate check.
> >>
> >> Signed-off-by: Stratos Karafotis <stratosk@...aphore.gr>
> >> ---
> >>   drivers/cpufreq/intel_pstate.c | 6 ------
> >>   1 file changed, 6 deletions(-)
> >>
> >> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> >> index aebd457..4e7f492 100644
> >> --- a/drivers/cpufreq/intel_pstate.c
> >> +++ b/drivers/cpufreq/intel_pstate.c
> >> @@ -691,14 +691,8 @@ MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> >>
> >>   static int intel_pstate_init_cpu(unsigned int cpunum)
> >>   {
> >> -
> >> -       const struct x86_cpu_id *id;
> >>          struct cpudata *cpu;
> >>
> >> -       id = x86_match_cpu(intel_pstate_cpu_ids);
> >> -       if (!id)
> >> -               return -ENODEV;
> >> -
> >>          all_cpu_data[cpunum] = kzalloc(sizeof(struct cpudata), GFP_KERNEL);
> >>          if (!all_cpu_data[cpunum])
> >>                  return -ENOMEM;
> >
> > Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> >
> Acked-by: Dirk Brandewie <dirk.j.brandewie@...el.com>

[1/7] applied, please wait with the rest until after 3.16-rc1 is released.

Thanks!

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/