lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Jun 2014 16:04:52 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: "George Spelvin" <linux@...izon.com> Cc: rdunlap@...radead.org, tj@...nel.org, linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, mingo@...hat.com Subject: Re: [PATCH v2 2/3] lib: glob.c: Add CONFIG_GLOB_SELFTEST On 6 Jun 2014 22:49:28 -0400 "George Spelvin" <linux@...izon.com> wrote: > This was useful during development, and is retained for future regression > testing. > > GCC appears to have no way to place string literals in a particular > section; adding __initconst to a char pointer leaves the string itself > in the default string section, where it will not be thrown away after > module load. > > Thus all string constants are kept in explicitly declared and named > arrays. Sorry this makes printk a bit harder to read. At least the > tests are more compact. > > Signed-off-by: George Spelvin <linux@...izon.com> > --- > Persuading GCC to throw away *all* the self-test data after running > it was surprisingly annoying. Yeah. Props for making the attempt. > The one thing I'm not really sure about is what to do if the self-test > fails. For now, I make the module_init function fail too. Opinions? The printk should suffice - someone will notice it eventually. Using KERN_ERR to report a failure might help draw attention to it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists