lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jun 2014 16:41:40 +0900 From: Joonsoo Kim <iamjoonsoo.kim@....com> To: Minchan Kim <minchan@...nel.org> Cc: Andrew Morton <akpm@...ux-foundation.org>, "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Michal Nazarewicz <mina86@...a86.com>, Russell King - ARM Linux <linux@....linux.org.uk>, kvm@...r.kernel.org, linux-mm@...ck.org, Gleb Natapov <gleb@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alexander Graf <agraf@...e.de>, kvm-ppc@...r.kernel.org, linux-kernel@...r.kernel.org, Paul Mackerras <paulus@...ba.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paolo Bonzini <pbonzini@...hat.com>, linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity On Thu, Jun 12, 2014 at 04:08:11PM +0900, Minchan Kim wrote: > On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: > > ppc kvm's cma region management requires arbitrary bitmap granularity, > > since they want to reserve very large memory and manage this region > > with bitmap that one bit for several pages to reduce management overheads. > > So support arbitrary bitmap granularity for following generalization. > > > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com> > Acked-by: Minchan Kim <minchan@...nel.org> > Thanks. [snip...] > > /** > > * dma_alloc_from_contiguous() - allocate pages from contiguous area > > * @dev: Pointer to device for which the allocation is performed. > > @@ -345,7 +372,8 @@ static void clear_cma_bitmap(struct cma *cma, unsigned long pfn, int count) > > static struct page *__dma_alloc_from_contiguous(struct cma *cma, int count, > > unsigned int align) > > { > > - unsigned long mask, pfn, pageno, start = 0; > > + unsigned long mask, pfn, start = 0; > > + unsigned long bitmap_maxno, bitmapno, nr_bits; > > Just Nit: bitmap_maxno, bitmap_no or something consistent. > I know you love consistent when I read description in first patch > in this patchset. ;-) Yeah, I will fix it. :) Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists