lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jun 2014 16:31:00 +0800 From: Zhang Yanfei <zhangyanfei@...fujitsu.com> To: Joonsoo Kim <iamjoonsoo.kim@....com> CC: Andrew Morton <akpm@...ux-foundation.org>, "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>, Marek Szyprowski <m.szyprowski@...sung.com>, Michal Nazarewicz <mina86@...a86.com>, Minchan Kim <minchan@...nel.org>, Russell King - ARM Linux <linux@....linux.org.uk>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Paolo Bonzini <pbonzini@...hat.com>, Gleb Natapov <gleb@...nel.org>, Alexander Graf <agraf@...e.de>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <kvm@...r.kernel.org>, <kvm-ppc@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org> Subject: Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path On 06/12/2014 11:21 AM, Joonsoo Kim wrote: > We can remove one call sites for clear_cma_bitmap() if we first > call it before checking error number. > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@....com> Reviewed-by: Zhang Yanfei <zhangyanfei@...fujitsu.com> > > diff --git a/mm/cma.c b/mm/cma.c > index 1e1b017..01a0713 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -282,11 +282,12 @@ struct page *cma_alloc(struct cma *cma, int count, unsigned int align) > if (ret == 0) { > page = pfn_to_page(pfn); > break; > - } else if (ret != -EBUSY) { > - clear_cma_bitmap(cma, pfn, count); > - break; > } > + > clear_cma_bitmap(cma, pfn, count); > + if (ret != -EBUSY) > + break; > + > pr_debug("%s(): memory range at %p is busy, retrying\n", > __func__, pfn_to_page(pfn)); > /* try again with a bit different memory target */ > -- Thanks. Zhang Yanfei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists