linux-kernel - Re: [PATCH] x86,build: Fix make -jN modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <539965EE.6050001@suse.cz>
Date:	Thu, 12 Jun 2014 10:33:50 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Andy Lutomirski <luto@...capital.net>
CC:	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kbuild@...r.kernel.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86,build: Fix make -jN modules_install install

Dne 11.6.2014 21:41, Andy Lutomirski napsal(a):
> Every few months, I forget why I type:
> 
> $ sudo make -j12 modules_install && sudo make -j12 install
> 
> instead of just:
> 
> $ sudo make -j12 modules_install install
> 
> I try the latter, it appears to work, and then my machine won't boot
> because dracut got confused.  This fixes it once and for all: if you
> ask make to install modules and a kernel, you almost certainly want
> the modules installed *first* so that your initramfs scripts can
> find the modules.
> 
> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> ---
>  arch/x86/Makefile | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/x86/Makefile b/arch/x86/Makefile
> index 33f71b0..7280d28 100644
> --- a/arch/x86/Makefile
> +++ b/arch/x86/Makefile
> @@ -240,6 +240,15 @@ PHONY += install
>  install:
>  	$(Q)$(MAKE) $(build)=$(boot) $@
>  
> +# If installing modules and a kernel, it's very likely that some initramfs
> +# script associated with installing the kernel will reference the modules,
> +# so make sure that modules are installed first.
> +ifneq ($(filter modules_install,$(MAKECMDGOALS)),)
> +  ifneq ($(filter modules_install,$(MAKECMDGOALS)),)

The two conditions are identical. Did you mean to check for "install" in
one of them?

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/