linux-kernel - Re: [PATCH] mmc: sdhci-msm: Fix fallout from sdhci refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Jun 2014 10:59:55 +0200
From:	Ulf Hansson <ulf.hansson@...aro.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Chris Ball <chris@...ntf.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Kevin Hilman <khilman@...aro.org>,
	Georgi Djakov <gdjakov@...sol.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCH] mmc: sdhci-msm: Fix fallout from sdhci refactoring

On 10 June 2014 20:27, Stephen Boyd <sboyd@...eaurora.org> wrote:
> The sdhci core was refactored recently and some of those
> refactorings required changes in every sdhci platform driver.
> Those updates happened around the same time as when the msm
> driver was merged so the refactorings missed the msm driver.
> Hook in the basic library functions so that we can boot apq8074
> dragonboards again instead of crashing when we try to jump to
> NULL function pointers.
>
> Reported-by: Kevin Hilman <khilman@...aro.org>
> Cc: Georgi Djakov <gdjakov@...sol.com>
> Cc: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>

Thanks!

Applied for fixes.

Kind regards
Uffe

> ---
>
> Patch based on next-20140610
>
>  drivers/mmc/host/sdhci-msm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index acb0e9eb55f1..40573a58486a 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -468,6 +468,10 @@ MODULE_DEVICE_TABLE(of, sdhci_msm_dt_match);
>
>  static struct sdhci_ops sdhci_msm_ops = {
>         .platform_execute_tuning = sdhci_msm_execute_tuning,
> +       .reset = sdhci_reset,
> +       .set_clock = sdhci_set_clock,
> +       .set_bus_width = sdhci_set_bus_width,
> +       .set_uhs_signaling = sdhci_set_uhs_signaling,
>  };
>
>  static int sdhci_msm_probe(struct platform_device *pdev)
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/