linux-kernel - Re: [PATCH] arch/score/kernel/process.c: Remove useless varialbes 'ti' and 'regs'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Jun 2014 17:52:44 +0800
From:	Liqin Chen <liqin.linux@...il.com>
To:	Chen Gang <gang.chen.5i5j@...il.com>
Cc:	Lennox Wu <lennox.wu@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arch/score/kernel/process.c: Remove useless varialbes
 'ti' and 'regs'

It's ok for S+core
Thanks.

Acked-by: Chen Liqin<liqin.linux@...il.com>

2014-06-08 14:58 GMT+08:00 Chen Gang <gang.chen.5i5j@...il.com>:
> They are useless, so remove them, the related warning (with
> allmodconfig under score):
>
>     CC      arch/score/kernel/process.o
>   arch/score/kernel/process.c: In function 'copy_thread':
>   arch/score/kernel/process.c:76:18: warning: unused variable 'regs' [-Wunused-variable]
>     struct pt_regs *regs = current_pt_regs();
>                     ^
>   arch/score/kernel/process.c:74:22: warning: unused variable 'ti' [-Wunused-variable]
>     struct thread_info *ti = task_thread_info(p);
>                         ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  arch/score/kernel/process.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/score/kernel/process.c b/arch/score/kernel/process.c
> index a1519ad3..50bf1b0 100644
> --- a/arch/score/kernel/process.c
> +++ b/arch/score/kernel/process.c
> @@ -71,9 +71,7 @@ void flush_thread(void) {}
>  int copy_thread(unsigned long clone_flags, unsigned long usp,
>                 unsigned long arg, struct task_struct *p)
>  {
> -       struct thread_info *ti = task_thread_info(p);
>         struct pt_regs *childregs = task_pt_regs(p);
> -       struct pt_regs *regs = current_pt_regs();
>
>         p->thread.reg0 = (unsigned long) childregs;
>         if (unlikely(p->flags & PF_KTHREAD)) {
> --
> 1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/