lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Jun 2014 11:59:20 +0200 From: Takashi Iwai <tiwai@...e.de> To: Vinod Koul <vinod.koul@...el.com> Cc: "Wang, Xiaoming" <xiaoming.wang@...el.com>, jeeja.kp@...el.com, dhowells@...hat.com, arnd@...db.de, tglx@...utronix.de, mtk.manpages@...il.com, paulmck@...ux.vnet.ibm.com, davej@...hat.com, linux-kernel@...r.kernel.org, dongxing.zhang@...el.com Subject: Re: [PATCH] ALSA: compress: Cancel the optimization of compiler and fix the size of struct for all platform. At Thu, 12 Jun 2014 14:55:13 +0530, Vinod Koul wrote: > > On Thu, Jun 12, 2014 at 06:47:07PM -0400, Wang, Xiaoming wrote: > > Cancel the optimization of compiler for struct snd_compr_avail > > which size will be 0x1c in 32bit kernel while 0x20 in 64bit > > kernel under the optimizer. That will make compaction between > > 32bit and 64bit. So add packed to fix the size of struct > > snd_compr_avail to 0x1c for all platform. > > > > Signed-off-by: Zhang Dongxing <dongxing.zhang@...el.com> > > Signed-off-by: xiaoming wang <xiaoming.wang@...el.com> > > Acked-by: Vinod Koul <vinod.koul@...el.com> > > Takashi, can we cc stable on this, would help fixing in older kernels too Yes, applied with Cc to stable now. thanks, Takashi > > Thanks > -- > ~Vinod > > --- > > include/uapi/sound/compress_offload.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/uapi/sound/compress_offload.h b/include/uapi/sound/compress_offload.h > > index 5759810..21eed48 100644 > > --- a/include/uapi/sound/compress_offload.h > > +++ b/include/uapi/sound/compress_offload.h > > @@ -80,7 +80,7 @@ struct snd_compr_tstamp { > > struct snd_compr_avail { > > __u64 avail; > > struct snd_compr_tstamp tstamp; > > -}; > > +} __attribute__((packed)); > > > > enum snd_compr_direction { > > SND_COMPRESS_PLAYBACK = 0, > > -- > > 1.7.1 > > > > -- > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists