linux-kernel - Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jun 2014 09:10:42 -0400
From:	Jason Cooper <jason@...edaemon.net>
To:	Sricharan R <r.sricharan@...com>
Cc:	linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	tony@...mide.com, santosh.shilimkar@...com, nm@...com,
	rnayak@...com, linux@....linux.org.uk, tglx@...utronix.de
Subject: Re: [PATCH V2 08/19] irqchip: crossbar: fix checkpatch warning

On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote:
> From: Nishanth Menon <nm@...com>
> 
> remove un-necessary space in function pointer.
> 
> Fixes checkpatch warning:
> WARNING: Unnecessary space before function pointer arguments
>  #37: FILE: drivers/irqchip/irq-crossbar.c:37:
>  +	void (*write) (int, int);
> 
> WARNING: Missing a blank line after declarations
> +	int *register_offsets;
> +	void (*write)(int, int);
> 
> WARNING: Prefer kcalloc over kzalloc with multiply
> +	cb->irq_map = kzalloc(max * sizeof(int), GFP_KERNEL);
> 
> WARNING: Prefer kcalloc over kzalloc with multiply
> +	cb->register_offsets = kzalloc(max * sizeof(int), GFP_KERNEL);
> 
> Signed-off-by: Nishanth Menon <nm@...com>
> ---
>  drivers/irqchip/irq-crossbar.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
> index 5da9d36..58790d4 100644
> --- a/drivers/irqchip/irq-crossbar.c
> +++ b/drivers/irqchip/irq-crossbar.c
> @@ -34,7 +34,8 @@ struct crossbar_device {
>  	uint *irq_map;
>  	void __iomem *crossbar_base;
>  	int *register_offsets;
> -	void (*write) (int, int);
> +
> +	void (*write)(int, int);

The empty line here looks bogus to me.  Did you re-run checkpatch after
fixing the unnecessary space to see if it still complained about having
a 'blank line after declarations'?

>  };
>  
>  /**
> @@ -150,7 +151,7 @@ static int __init crossbar_of_init(struct device_node *node,
>  		goto err1;
>  
>  	of_property_read_u32(node, "ti,max-irqs", &max);
> -	cb->irq_map = kzalloc(max * sizeof(int), GFP_KERNEL);
> +	cb->irq_map = kcalloc(max, sizeof(int), GFP_KERNEL);
>  	if (!cb->irq_map)
>  		goto err2;
>  
> @@ -176,7 +177,7 @@ static int __init crossbar_of_init(struct device_node *node,
>  		}
>  	}
>  
> -	cb->register_offsets = kzalloc(max * sizeof(int), GFP_KERNEL);
> +	cb->register_offsets = kcalloc(max, sizeof(int), GFP_KERNEL);
>  	if (!cb->register_offsets)
>  		goto err3;

I'm generally opposed to these sorts of checkpatch patches, especially
when they are just warnings.  It's great for a new driver in the staging
tree, but it makes backporting future bugfixes that much harder when
drivers have been live in mainline.

If, in the future, you're changing code in this area, go ahead and
convert to kcalloc(), but I wouldn't do a separate patch for this kind
of thing.

Honestly, I would just drop this patch and not worry about it.

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/